Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Create Shapeshift OG (WIP) #10

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Create Shapeshift OG (WIP) #10

wants to merge 3 commits into from

Conversation

cmccand
Copy link

@cmccand cmccand commented Jul 31, 2022

Description

  • create Swap page
  • add SimpleSwap component
  • add classic and modern cards
  • add subsequent steps
  • make page responsive

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

Testing

Screenshots (if applicable)

Modern Skin

Desktop
image

Mobile
image

OG Skin

Desktop
image

Mobile
image

Copy link

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one nic/pick the code looks good to me.

I'll do some more QA locally once those few bugs that were previously discussed are worked on. Just let me know @cmccand and I'll do a jump on and get a review done.

src/pages/Swap/SimpleSwap.tsx Show resolved Hide resolved
@Da-Colon
Copy link

Da-Colon commented Aug 6, 2022

OG SWAP tooltip

Can we update this to just say 'Swap"

@cmccand
Copy link
Author

cmccand commented Aug 17, 2022

OG SWAP tooltip

Can we update this to just say 'Swap"

Yeah I noticed that the other day too, haha. I just needed to add the localization string. Thanks for calling out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants